ci: only rebuild changed images
Build containers / fedora-cosmic (44) (pull_request) Canceled after 0s
Build containers / fedora-cosmic (rawhide) (pull_request) Canceled after 0s
Build containers / fedora-remote (44) (pull_request) Canceled after 0s
Build containers / fedora-intune (44) (pull_request) Canceled after 0s
Build containers / Compute changes (pull_request) Canceled after 9s
Build containers / Prune old releases and tags (pull_request) Skipped

The changes job ran on the bare runner, which has no git (the build jobs
install it before checkout). actions/checkout then fell back to a tarball
without history, `git diff` failed, `|| true` turned that into an empty
change list, and an empty list means "rebuild everything" - on every push
and PR.

Run the job in the buildroot container with git and nodejs, warn when the
diff fails instead of hiding it, treat a diff with no changes as "build
nothing", and let a manual run pick one image. The weekly scheduled run
still rebuilds all images for package updates.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Wesley van TilburgandClaude Opus 5.5 committed 2026-10-20 09:21:08 +00:00
1 parent 2b78113124
commit 1dbe7f6895
1 file changed
+57 -9
+57 -9
View File
@@ -2,6 +2,12 @@ name: Build containers
on:
workflow_dispatch:
inputs:
image:
description: Image to build
type: choice
options: [all, fedora-cosmic, fedora-remote, fedora-intune]
default: all
pull_request:
branches: ["main"]
push:
@@ -15,11 +21,17 @@ jobs:
changes:
name: Compute changes
runs-on: job-v2
# The runner has no git: without it actions/checkout falls back to a
# tarball with no history, `git diff` fails and every image is rebuilt.
container:
image: "quay.io/fedora-ostree-desktops/buildroot:44"
outputs:
cosmic: ${{ steps.changes.outputs.cosmic }}
remote: ${{ steps.changes.outputs.remote }}
intune: ${{ steps.changes.outputs.intune }}
steps:
- name: Install tools
run: dnf install -y nodejs git
- name: Checkout
uses: actions/checkout@v4
with:
@@ -27,17 +39,53 @@ jobs:
- name: Detect changed images
id: changes
shell: bash
env:
EVENT: ${{ github.event_name }}
BEFORE: ${{ github.event.before }}
SHA: ${{ github.sha }}
BASE_REF: ${{ github.base_ref }}
DISPATCH_IMAGE: ${{ inputs.image }}
run: |
set -euo pipefail
if [[ "${{ github.event_name }}" == "push" \
&& -n "${{ github.event.before }}" \
&& "${{ github.event.before }}" != "0000000000000000000000000000000000000000" ]]; then
changed="$(git diff --name-only "${{ github.event.before }}" "${{ github.sha }}" || true)"
elif [[ "${{ github.event_name }}" == "pull_request" ]]; then
changed="$(git diff --name-only "origin/${{ github.base_ref }}...HEAD" || true)"
else
changed=""
fi
# Diff the event's commits; any failure rebuilds everything, but
# say so instead of hiding it.
diff_or_all() {
if ! changed="$(git diff --name-only "$@")"; then
echo "::warning::git diff $* failed; rebuilding every image"
changed=""
elif [[ -z "${changed}" ]]; then
# Nothing changed (e.g. an empty merge): build nothing rather
# than everything.
changed="(none)"
fi
}
case "${EVENT}" in
push)
if [[ -n "${BEFORE}" && "${BEFORE}" != 0000000000000000000000000000000000000000 ]]; then
diff_or_all "${BEFORE}" "${SHA}"
else
echo "::warning::push without a previous commit; rebuilding every image"
changed=""
fi
;;
pull_request)
diff_or_all "origin/${BASE_REF}...HEAD"
;;
workflow_dispatch)
# Pretend the chosen image's directory changed; "all" (or no
# input) rebuilds everything.
if [[ -n "${DISPATCH_IMAGE}" && "${DISPATCH_IMAGE}" != all ]]; then
changed="images/${DISPATCH_IMAGE}/"
else
changed=""
fi
;;
*)
# schedule: the weekly rebuild picks up package updates for all.
changed=""
;;
esac
printf 'Changed paths:\n%s\n' "${changed:-(all)}"
eval "$(printf '%s\n' "${changed}" | ./ci-changes.sh)"
echo "cosmic=${cosmic}" >> "$GITHUB_OUTPUT"
echo "remote=${remote}" >> "$GITHUB_OUTPUT"