Fix problem details layout, fixes #1252

This commit is contained in:
Alexander Zobnin
2021-08-03 13:57:26 +03:00
parent 12c4089a50
commit 201d6cb19a
2 changed files with 113 additions and 93 deletions

View File

@@ -102,25 +102,16 @@ export class ProblemDetails extends PureComponent<ProblemDetailsProps, ProblemDe
return ( return (
<div className={`problem-details-container ${displayClass}`}> <div className={`problem-details-container ${displayClass}`}>
<div className="problem-details"> <div className="problem-details-head">
<div className="problem-details-row">
<div className="problem-value-container">
<div className="problem-age">
<FAIcon icon="clock-o" />
<span>{age}</span>
</div>
{problem.items && <ProblemItems items={problem.items} />}
</div>
<div className="problem-actions-left"> <div className="problem-actions-left">
<ExploreButton problem={problem} panelId={this.props.panelId} /> <ExploreButton problem={problem} panelId={this.props.panelId} />
</div> </div>
<ProblemStatusBar problem={problem} alerts={alerts} className={compactStatusBar && 'compact'} />
{problem.showAckButton && {problem.showAckButton &&
<div className="problem-actions"> <div className="problem-actions">
<ModalController> <ModalController>
{({ showModal, hideModal }) => ( {({ showModal, hideModal }) => (
<ExecScriptButton <ExecScriptButton
className="navbar-button navbar-button--settings" className="problem-action-button"
onClick={() => { onClick={() => {
showModal(ExecScriptModal, { showModal(ExecScriptModal, {
getScripts: this.getScripts, getScripts: this.getScripts,
@@ -134,7 +125,7 @@ export class ProblemDetails extends PureComponent<ProblemDetailsProps, ProblemDe
<ModalController> <ModalController>
{({ showModal, hideModal }) => ( {({ showModal, hideModal }) => (
<AckButton <AckButton
className="navbar-button navbar-button--settings" className="problem-action-button"
onClick={() => { onClick={() => {
showModal(AckModal, { showModal(AckModal, {
canClose: problem.manual_close === '1', canClose: problem.manual_close === '1',
@@ -148,6 +139,18 @@ export class ProblemDetails extends PureComponent<ProblemDetailsProps, ProblemDe
</ModalController> </ModalController>
</div> </div>
} }
<ProblemStatusBar problem={problem} alerts={alerts} className={compactStatusBar && 'compact'} />
</div>
<div className="problem-details-body">
<div className="problem-details">
<div className="problem-details-row">
<div className="problem-value-container">
<div className="problem-age">
<FAIcon icon="clock-o" />
<span>{age}</span>
</div>
{problem.items && <ProblemItems items={problem.items} />}
</div>
</div> </div>
{problem.comments && {problem.comments &&
<div className="problem-description-row"> <div className="problem-description-row">
@@ -204,6 +207,7 @@ export class ProblemDetails extends PureComponent<ProblemDetailsProps, ProblemDe
{problem.hosts && <ProblemHosts hosts={problem.hosts} className="problem-details-right-item" />} {problem.hosts && <ProblemHosts hosts={problem.hosts} className="problem-details-right-item" />}
</div> </div>
</div> </div>
</div>
); );
} }
} }

View File

@@ -215,6 +215,7 @@
.problem-details-container { .problem-details-container {
display: flex; display: flex;
flex-direction: column;
padding-top: 4px; padding-top: 4px;
background-color: $problem-details-background; background-color: $problem-details-background;
border-bottom-width: 0px; border-bottom-width: 0px;
@@ -227,7 +228,7 @@
transition-property: opacity, max-height; transition-property: opacity, max-height;
&.show { &.show {
max-height: 20rem; max-height: 23rem;
opacity: 1; opacity: 1;
box-shadow: inset -3px 3px 10px $problem-container-shadow; box-shadow: inset -3px 3px 10px $problem-container-shadow;
} }
@@ -244,6 +245,15 @@
} }
} }
.problem-details-head {
display: flex;
padding: 0.5rem 1rem 0.5rem 1.2rem;
}
.problem-details-body {
display: flex;
}
.problem-details { .problem-details {
position: relative; position: relative;
flex: 10 1 auto; flex: 10 1 auto;
@@ -256,7 +266,8 @@
.problem-description { .problem-description {
position: relative; position: relative;
height: 4.5rem; max-height: 4.5rem;
min-height: 3rem;
overflow: hidden; overflow: hidden;
&:after { &:after {
@@ -358,7 +369,11 @@
.problem-actions { .problem-actions {
display: flex; display: flex;
margin-left: 1.6rem; margin-right: 1.6rem;
}
.problem-action-button {
margin-right: 0.2rem;
} }
.problem-actions-left { .problem-actions-left {
@@ -376,6 +391,7 @@
} }
.problem-ack-container { .problem-ack-container {
max-height: 8rem;
margin-top: 0.6rem; margin-top: 0.6rem;
margin-left: -0.6rem; margin-left: -0.6rem;
padding: 1.2rem 0.6rem; padding: 1.2rem 0.6rem;