fixed a bug where mixed datasource with variable ref were not working (#1909)

This commit is contained in:
Sriram
2024-11-12 09:48:23 +00:00
committed by GitHub
parent b27194930c
commit 2c41cea0c4
2 changed files with 23 additions and 6 deletions

View File

@@ -14,7 +14,13 @@ import { ZabbixAPIError } from './zabbix/connectors/zabbix_api/zabbixAPIConnecto
import { ProblemDTO, VariableQueryTypes } from './types';
import { ZabbixMetricsQuery, ShowProblemTypes } from './types/query';
import { ZabbixDSOptions } from './types/config';
import { BackendSrvRequest, getBackendSrv, getTemplateSrv, toDataQueryResponse } from '@grafana/runtime';
import {
BackendSrvRequest,
getBackendSrv,
getTemplateSrv,
toDataQueryResponse,
getDataSourceSrv,
} from '@grafana/runtime';
import {
DataFrame,
dataFrameFromJSON,
@@ -119,10 +125,18 @@ export class ZabbixDatasource extends DataSourceApi<ZabbixMetricsQuery, ZabbixDS
trackRequest(request);
// Migrate old targets
const requestTargets = request.targets.map((t) => {
const requestTargets = request.targets
.map((t) => {
// Prevent changes of original object
const target = _.cloneDeep(t);
return migrations.migrate(target);
})
.map((target) => {
let ds = getDataSourceSrv().getInstanceSettings(target?.datasource);
if (ds?.rawRef?.uid) {
return { ...target, datasource: { ...target?.datasource, uid: ds.rawRef?.uid } };
}
return target;
});
const backendResponsePromise = this.backendQuery({ ...request, targets: requestTargets });

View File

@@ -12,6 +12,9 @@ jest.mock(
toPromise: () => jest.fn().mockResolvedValue({ data: { result: '' } }),
}),
}),
getDataSourceSrv: () => ({
getInstanceSettings: jest.fn().mockResolvedValue({}),
}),
getTemplateSrv: () => ({
replace: jest.fn().mockImplementation((query) => query),
}),