Refactor: zabbixCache renamed to zabbixCachingProxy.

This commit is contained in:
Alexander Zobnin
2016-11-14 18:01:54 +03:00
parent fd772fab15
commit d15e9c8acd
2 changed files with 10 additions and 10 deletions

View File

@@ -2,7 +2,7 @@ import angular from 'angular';
import _ from 'lodash'; import _ from 'lodash';
import * as utils from './utils'; import * as utils from './utils';
import './zabbixAPI.service.js'; import './zabbixAPI.service.js';
import './zabbixCache.service.js'; import './zabbixCachingProxy.service.js';
// Use factory() instead service() for multiple data sources support. // Use factory() instead service() for multiple data sources support.
// Each Zabbix data source instance should initialize its own API instance. // Each Zabbix data source instance should initialize its own API instance.
@@ -17,11 +17,11 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
var ZabbixAPI = zabbixAPIService; var ZabbixAPI = zabbixAPIService;
this.zabbixAPI = new ZabbixAPI(url, username, password, basicAuth, withCredentials); this.zabbixAPI = new ZabbixAPI(url, username, password, basicAuth, withCredentials);
// Initialize cache // Initialize caching proxy for requests
this.cache = new ZabbixCachingProxy(this.zabbixAPI, cacheTTL); this.cachingProxy = new ZabbixCachingProxy(this.zabbixAPI, cacheTTL);
// Proxy methods // Proxy methods
this.getHistory = this.cache.getHistory.bind(this.cache); this.getHistory = this.cachingProxy.getHistory.bind(this.cachingProxy);
this.getTrend = this.zabbixAPI.getTrend.bind(this.zabbixAPI); this.getTrend = this.zabbixAPI.getTrend.bind(this.zabbixAPI);
this.getEvents = this.zabbixAPI.getEvents.bind(this.zabbixAPI); this.getEvents = this.zabbixAPI.getEvents.bind(this.zabbixAPI);
@@ -38,7 +38,7 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
} }
getAllGroups() { getAllGroups() {
return this.cache.getGroups(); return this.cachingProxy.getGroups();
} }
getGroups(groupFilter) { getGroups(groupFilter) {
@@ -53,7 +53,7 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
return this.getGroups(groupFilter) return this.getGroups(groupFilter)
.then(groups => { .then(groups => {
let groupids = _.map(groups, 'groupid'); let groupids = _.map(groups, 'groupid');
return this.cache.getHosts(groupids); return this.cachingProxy.getHosts(groupids);
}); });
} }
@@ -69,7 +69,7 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
return this.getHosts(groupFilter, hostFilter) return this.getHosts(groupFilter, hostFilter)
.then(hosts => { .then(hosts => {
let hostids = _.map(hosts, 'hostid'); let hostids = _.map(hosts, 'hostid');
return this.cache.getApps(hostids); return this.cachingProxy.getApps(hostids);
}); });
} }
@@ -78,7 +78,7 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
.then(hosts => { .then(hosts => {
let hostids = _.map(hosts, 'hostid'); let hostids = _.map(hosts, 'hostid');
if (appFilter) { if (appFilter) {
return this.cache.getApps(hostids) return this.cachingProxy.getApps(hostids)
.then(apps => filterByQuery(apps, appFilter)); .then(apps => filterByQuery(apps, appFilter));
} else { } else {
return { return {
@@ -93,10 +93,10 @@ function ZabbixFactory(zabbixAPIService, ZabbixCachingProxy) {
return this.getApps(groupFilter, hostFilter, appFilter) return this.getApps(groupFilter, hostFilter, appFilter)
.then(apps => { .then(apps => {
if (apps.appFilterEmpty) { if (apps.appFilterEmpty) {
return this.cache.getItems(apps.hostids, undefined, options.itemtype); return this.cachingProxy.getItems(apps.hostids, undefined, options.itemtype);
} else { } else {
let appids = _.map(apps, 'applicationid'); let appids = _.map(apps, 'applicationid');
return this.cache.getItems(undefined, appids, options.itemtype); return this.cachingProxy.getItems(undefined, appids, options.itemtype);
} }
}) })
.then(items => { .then(items => {