Misthios/grafana-zabbix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix problems panel broken when selecting triggers (#1960)

Browse Source 
This PR fixes an issue where the problems panel breaks when you change
to query type to `Triggers`.

![](https://grafana.zendesk.com/attachments/token/MNBgVTPRKZkwa6TsMBbtBQdIp/?name=image.png)

How to reproduce:

1. Go to `Zabbix data source features` dashboard
2. Open Problems panel
3. Change`Query type` to `Triggers`
4. Select `Problems` from `Count by`
5. Change the `Group` to `Backend`
6. The problems panel should not error

---------

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
This commit is contained in:
Sriram
2025-02-24 10:01:08 +00:00
committed by GitHub
parent a5cfbfa7d9
commit f4376363eb
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/purple-carrots-rhyme.md Normal file
View File

@@ -0,0 +1,5 @@
---
'grafana-zabbix': patch
---
Fix problems panel broken when selecting triggers

5
src/panel-triggers/ProblemsPanel.tsx
View File

@@ -63,7 +63,7 @@ export const ProblemsPanel = (props: ProblemsPanelProps): JSX.Element => {
// Filter triggers by severity // Filter triggers by severity
problemsList = problemsList.filter((problem) => { problemsList = problemsList.filter((problem) => {
const severity = problem.severity !== undefined ? Number(problem.severity) : Number(problem.priority); const severity = problem.severity !== undefined ? Number(problem.severity) : Number(problem.priority);
return triggerSeverity[severity].show; return triggerSeverity[severity]?.show;
}); });
return problemsList; return problemsList;
@@ -100,8 +100,9 @@ export const ProblemsPanel = (props: ProblemsPanelProps): JSX.Element => {
if (trigger.comments && options.allowDangerousHTML) { if (trigger.comments && options.allowDangerousHTML) {
trigger.comments = trigger.comments.replace('\n', '<br>'); trigger.comments = trigger.comments.replace('\n', '<br>');
} }
if (trigger && typeof trigger === 'object') {
trigger.lastchangeUnix = Number(trigger.lastchange); trigger.lastchangeUnix = Number(trigger.lastchange);
}
return trigger; return trigger;
}; };