58902e7ed9
This PR fixes error source for 2 errors: - parsing of invalid json response should be downstream error as we expect to receive valid json from zabbix - no host found error should be downstream. We are bumping sdk that includes that fix https://github.com/grafana/grafana-plugin-sdk-go/pull/1246. As you can see - the invalid json parsing is now downstream error <img width="1498" alt="image" src="https://github.com/user-attachments/assets/88028dbe-0f73-47aa-8262-5729059ce12f" />
125 lines
3.3 KiB
Go
125 lines
3.3 KiB
Go
package zabbixapi
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana-plugin-sdk-go/backend"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var version = 65
|
|
|
|
|
|
func TestZabbixAPIUnauthenticatedQuery(t *testing.T) {
|
|
zabbixApi, _ := MockZabbixAPI(`{"result":"sampleResult"}`, 200)
|
|
resp, err := zabbixApi.RequestUnauthenticated(context.Background(), "test.get", map[string]interface{}{}, version)
|
|
|
|
assert.Equal(t, "sampleResult", resp.MustString())
|
|
assert.Nil(t, err)
|
|
}
|
|
|
|
func TestLogin(t *testing.T) {
|
|
zabbixApi, _ := MockZabbixAPI(`{"result":"secretauth"}`, 200)
|
|
err := zabbixApi.Authenticate(context.Background(), "user", "password", version)
|
|
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "secretauth", zabbixApi.auth)
|
|
}
|
|
|
|
func TestZabbixAPI(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
auth string
|
|
mockApiResponse string
|
|
mockApiResponseCode int
|
|
expectedResult string
|
|
expectedError error
|
|
version int
|
|
}{
|
|
{
|
|
name: "Simple request",
|
|
auth: "secretauth",
|
|
mockApiResponse: `{"result":"sampleResult"}`,
|
|
mockApiResponseCode: 200,
|
|
expectedResult: "sampleResult",
|
|
expectedError: nil,
|
|
},
|
|
{
|
|
name: "Request should return error if API not authenticated",
|
|
auth: "",
|
|
mockApiResponse: `{"result":"sampleResult"}`,
|
|
mockApiResponseCode: 200,
|
|
expectedResult: "",
|
|
expectedError: backend.DownstreamError(ErrNotAuthenticated),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
zabbixApi, _ := MockZabbixAPI(tt.mockApiResponse, tt.mockApiResponseCode)
|
|
zabbixApi.auth = tt.auth
|
|
resp, err := zabbixApi.Request(context.Background(), "test.get", map[string]interface{}{}, version)
|
|
|
|
if tt.expectedError != nil {
|
|
assert.Equal(t, err, tt.expectedError)
|
|
} else {
|
|
assert.NotNil(t, resp)
|
|
// assert.Equal(t, tt.expectedResult, resp.MustString())
|
|
assert.Nil(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestHandleAPIResult(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
response string
|
|
expectedData interface{}
|
|
expectedError string
|
|
isDownstream bool
|
|
}{
|
|
{
|
|
name: "Valid JSON with result",
|
|
response: `{"result": {"data": "test"}}`,
|
|
expectedData: map[string]interface{}{"data": "test"},
|
|
},
|
|
{
|
|
name: "Invalid JSON",
|
|
response: `{"result": invalid}`,
|
|
expectedError: "invalid character 'i' looking for beginning of value",
|
|
isDownstream: true,
|
|
},
|
|
{
|
|
name: "API error response",
|
|
response: `{"error": {"message": "Authentication failed", "data": "Session terminated"}}`,
|
|
expectedError: "Authentication failed Session terminated",
|
|
isDownstream: true,
|
|
},
|
|
{
|
|
name: "Empty result",
|
|
response: `{"result": []}`,
|
|
expectedData: []interface{}{},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
result, err := handleAPIResult([]byte(tt.response))
|
|
|
|
if tt.expectedError != "" {
|
|
assert.Error(t, err)
|
|
assert.Equal(t, tt.expectedError, err.Error())
|
|
if tt.isDownstream {
|
|
assert.True(t, backend.IsDownstreamError(err), "error should be a downstream error")
|
|
}
|
|
return
|
|
}
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, tt.expectedData, result.Interface())
|
|
})
|
|
}
|
|
}
|